kdebase 3.5.8-9 fc8 x86_64

[Eli Wapniarski]

Hi Rex

The patch included in the new build reintroduced the kded crash

I recompiled the source with the older patch and kded stopped crashing

So... it would seem

--- kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp.orig
2007-08-30 14:45:33.000000000 +0200
+++ kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp 2007-08-30
15:03:16.000000000 +0200
@@ -990,8 +990,11 @@

QString HALBackend::listUsingProcesses(const Medium* medium)
{
- QString proclist, fullmsg;
- QString cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ QString proclist, fullmsg, cmdline;
+ if(QFile::exists("/sbin/fuser"))
+ cmdline = QString("/sbin/fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ else
+ cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
FILE *fuser = popen(cmdline.latin1(), "r");

uint counter = 0;


BAD...


Index: kioslave/media/mediamanager/halbackend.cpp
===================================================================
--- kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724099)
+++ kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724100)
@@ -74,7 +74,10 @@
const QPtrList<Medium> medlist = m_mediaList.list();
QPtrListIterator<Medium> it (medlist);
for ( const Medium *current_medium = it.current(); current_medium;
current_medium = ++it)
- unmount(current_medium->id());
+ {
+ if( !current_medium->id().startsWith( "/org/kde" ))
+ unmount(current_medium->id());
+ }


/* Remove all the registered media first */


GOOD...


:)

Eli
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Rex Dieter]

Post by Eli Wapniarski
Hi Rex
The patch included in the new build reintroduced the kded crash

I've not included hal patches in any recent build. ??
The latest build includes a patch to fix a kdm/XDMCP issue, that's the
only difference,

%changelog
* Wed Nov 28 2007 Rex Dieter <rdieter[AT]fedoraproject.org> - 6:3.5.8-9
- adapt mandriva's consolekit patch to fix xdmcp issues (#243560)


-- Rex

Post by Eli Wapniarski
I recompiled the source with the older patch and kded stopped crashing
So... it would seem
--- kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp.orig
2007-08-30 14:45:33.000000000 +0200
+++ kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp 2007-08-30
15:03:16.000000000 +0200
@@ -990,8 +990,11 @@
QString HALBackend::listUsingProcesses(const Medium* medium)
{
- QString proclist, fullmsg;
- QString cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ QString proclist, fullmsg, cmdline;
+ if(QFile::exists("/sbin/fuser"))
+ cmdline = QString("/sbin/fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ else
+ cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
FILE *fuser = popen(cmdline.latin1(), "r");
uint counter = 0;
BAD...
Index: kioslave/media/mediamanager/halbackend.cpp
===================================================================
--- kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724099)
+++ kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724100)
@@ -74,7 +74,10 @@
const QPtrList<Medium> medlist = m_mediaList.list();
QPtrListIterator<Medium> it (medlist);
for ( const Medium *current_medium = it.current(); current_medium;
current_medium = ++it)
- unmount(current_medium->id());
+ {
+ if( !current_medium->id().startsWith( "/org/kde" ))
+ unmount(current_medium->id());
+ }
/* Remove all the registered media first */
GOOD...
:)
Eli

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Eli Wapniarski]

Ahh... OK... My misunderstanding. Sorry.

Eli

Post by Rex Dieter

Post by Eli Wapniarski
Hi Rex
The patch included in the new build reintroduced the kded crash

I've not included hal patches in any recent build. ??
The latest build includes a patch to fix a kdm/XDMCP issue, that's the
only difference,
%changelog
* Wed Nov 28 2007 Rex Dieter <rdieter[AT]fedoraproject.org> - 6:3.5.8-9
- adapt mandriva's consolekit patch to fix xdmcp issues (#243560)
-- Rex

Post by Eli Wapniarski
I recompiled the source with the older patch and kded stopped crashing
So... it would seem
--- kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp.orig
2007-08-30 14:45:33.000000000 +0200
+++ kdebase-3.5.7/kioslave/media/mediamanager/halbackend.cpp
2007-08-30 15:03:16.000000000 +0200
@@ -990,8 +990,11 @@
QString HALBackend::listUsingProcesses(const Medium* medium)
{
- QString proclist, fullmsg;
- QString cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ QString proclist, fullmsg, cmdline;
+ if(QFile::exists("/sbin/fuser"))
+ cmdline = QString("/sbin/fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
+ else
+ cmdline = QString("/usr/bin/env fuser -vm %1
2>&1").arg(KProcess::quote(medium->mountPoint()));
FILE *fuser = popen(cmdline.latin1(), "r");
uint counter = 0;
BAD...
Index: kioslave/media/mediamanager/halbackend.cpp
===================================================================
--- kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724099)
+++ kdebase-3.5.8/kioslave/media/mediamanager/halbackend.cpp (revision
724100)
@@ -74,7 +74,10 @@
const QPtrList<Medium> medlist = m_mediaList.list();
QPtrListIterator<Medium> it (medlist);
for ( const Medium *current_medium = it.current();
current_medium; current_medium = ++it)
- unmount(current_medium->id());
+ {
+ if( !current_medium->id().startsWith( "/org/kde" ))
+ unmount(current_medium->id());
+ }
/* Remove all the registered media first */
GOOD...
:)
Eli

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplac
e _______________________________________________
kde-redhat-users mailing list
https://lists.sourceforge.net/lists/listinfo/kde-redhat-users

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Rex Dieter]

Post by Eli Wapniarski
Hi Rex
The patch included in the new build reintroduced the kded crash

Come to think about it (the "kded crash"), has anyone reported this yet
to bugs.kde.org? If not, would probably not be a bad idea... :)

If it has already been reported, please let me know the bz#.

-- Rex

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Eli Wapniarski]

Post by Rex Dieter

Post by Eli Wapniarski
Hi Rex
The patch included in the new build reintroduced the kded crash

Come to think about it (the "kded crash"), has anyone reported this yet
to bugs.kde.org? If not, would probably not be a bad idea... :)

Just did at: http://bugs.kde.org/show_bug.cgi?id=154039

Rex, I added your email address to the cc list

Eli
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.


-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

[Rex Dieter]

Post by Eli Wapniarski

Post by Rex Dieter

Post by Eli Wapniarski
Hi Rex
The patch included in the new build reintroduced the kded crash

Come to think about it (the "kded crash"), has anyone reported this yet
to bugs.kde.org? If not, would probably not be a bad idea... :)

Just did at: http://bugs.kde.org/show_bug.cgi?id=154039
Rex, I added your email address to the cc list

Thanks!

-- Rex

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace